fix: preserve NULL semantics in log and power simplification - #24247
Merged
Jefffrey merged 1 commit intoAug 12, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24247 +/- ##
==========================================
- Coverage 81.06% 81.01% -0.05%
==========================================
Files 1106 1106
Lines 382252 383982 +1730
Branches 382252 383982 +1730
==========================================
+ Hits 309861 311080 +1219
- Misses 54083 54561 +478
- Partials 18308 18341 +33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alamb
approved these changes
Aug 11, 2026
Jefffrey
approved these changes
Aug 12, 2026
Contributor
kosiew
pushed a commit
to kosiew/datafusion
that referenced
this pull request
Aug 12, 2026
…che#24247) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Part of apache#24246. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. Please explain the problem you are trying to solve in terms of the user-visible behavior, rather than the implementation. For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the implementation. "COUNT(DISTINCT) returns wrong results when the column contains nulls" is the user-visible problem. --> `log` and `power` simplifications removed a nullable base expression, which could incorrectly produce a non-NULL result when the base was NULL. For example: ```sql SELECT log(a, 1.0), power(a, 0.0) FROM (VALUES (NULL::DOUBLE)) AS t(a); ``` These expressions should both return NULL, but simplification could replace them with 0.0 and 1.0. ## What changes are included in this PR? only apply these simplifications when the removed base expression is non-nullable. <!-- There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Yes. Added sqllogictests covering results and plans. ## Are there any user-facing changes? Yes. log and power expressions with nullable bases now correctly preserve NULLs. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please add the `api change` label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
logandpowersimplifications removed a nullable base expression, which could incorrectly produce a non-NULL result when the base was NULL.For example:
These expressions should both return NULL, but simplification could replace them with 0.0 and 1.0.
What changes are included in this PR?
only apply these simplifications when the removed base expression is non-nullable.
Are these changes tested?
Yes. Added sqllogictests covering results and plans.
Are there any user-facing changes?
Yes. log and power expressions with nullable bases now correctly preserve NULLs.